From 4dd45602c91f12d4fa8eb93d7e32c45c66dd64d4 Mon Sep 17 00:00:00 2001
From: Daniel Espinosa <esodan@gmail.com>
Date: Fri, 4 Nov 2016 14:20:27 -0600
Subject: [PATCH] GomObject: Fixed set_attribute return value

---
 gxml/GomObject.vala | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gxml/GomObject.vala b/gxml/GomObject.vala
index 3889212b..05d83e80 100644
--- a/gxml/GomObject.vala
+++ b/gxml/GomObject.vala
@@ -122,7 +122,7 @@ public interface GXml.GomObject : GLib.Object,
         } catch {
           GLib.warning (_("Enumeration is out of range"));
         }
-        return "";
+        return null;
       }
     }
     return null;
@@ -152,22 +152,27 @@ public interface GXml.GomObject : GLib.Object,
       if (prop.value_type.is_a (typeof (string))) {
         v.set_string (val);
         set_property (prop.name, v);
+        return true;
       }
       if (prop.value_type.is_a (typeof (int))) {
         v.set_string (val);
         set_property (prop.name, v);
+        return true;
       }
       if (prop.value_type.is_a (typeof (uint))) {
         v.set_string (val);
         set_property (prop.name, v);
+        return true;
       }
       if (prop.value_type.is_a (typeof (double))) {
         v.set_string (val);
         set_property (prop.name, v);
+        return true;
       }
       if (prop.value_type.is_a (typeof (bool))) {
         v.set_string (val);
         set_property (prop.name, v);
+        return true;
       }
       if (prop.value_type.is_a (Type.ENUM)) {
         try {
@@ -175,7 +180,9 @@ public interface GXml.GomObject : GLib.Object,
           v.set_enum (n);
         } catch {
           GLib.warning (_("Enumeration can't be parsed from string"));
+          return false;
         }
+        return true;
       }
     }
     return false;
-- 
GitLab